Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

370 again integration test failures because of snapshot changes #371

Merged
merged 6 commits into from
Mar 25, 2024
Merged

370 again integration test failures because of snapshot changes #371

merged 6 commits into from
Mar 25, 2024

Conversation

BFalquet
Copy link
Contributor

#370

This is a prototype to replace the plot snapshot testing and avoid test failure due to minimal changes in the plotting.

  • introduce a test argument in the barplot module. If TRUE, the structure (layer_data) of the plot is rendered.
  • the snapshot test is now performed on the underlying data rather than on the plot itself

thank you for your review and suggestions

danielinteractive
danielinteractive approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks @BFalquet

@BFalquet BFalquet marked this pull request as ready for review March 22, 2024 14:53
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 22, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/adtteSpec.R           170     123  27.65%   253-400
R/assaySpec.R            53      39  26.42%   104-146
R/barplot.R             187     151  19.25%   39-66, 129-279
R/boxplot.R             189     158  16.40%   40-67, 125-278
R/checkmate.R            18       9  50.00%   110-118
R/experimentSpec.R       90      57  36.67%   97, 215-283
R/forestplot.R          213     185  13.15%   58-92, 152-326
R/geneSpec.R            256     153  40.23%   154-169, 296-480
R/km.R                  207     173  16.43%   61-92, 156-325
R/pca.R                 366     283  22.68%   34-56, 165-476
R/quality.R             319     246  22.88%   18-110, 208-453
R/sampleVarSpec.R       236     104  55.93%   299, 318-327, 333-340, 342, 350-362, 364-365, 367, 370, 378-382, 384-399, 404-428, 431-435, 437, 444-454, 456-457, 465, 510-527
R/scatterplot.R         180     147  18.33%   39-65, 127-272
R/utils.R                16       0  100.00%
R/volcanoplot.R         203     173  14.78%   34-57, 113-292
R/zzz.R                   2       2  0.00%    2-3
TOTAL                  2705    2003  25.95%

Diff against main

Filename           Stmts    Miss  Cover
---------------  -------  ------  -------
R/barplot.R          +14     +11  +0.18%
R/boxplot.R          +13     +10  +0.49%
R/forestplot.R       +13     +10  +0.65%
R/km.R               +15     +12  +0.28%
R/pca.R               +9      +7  -0.01%
R/quality.R          +17     +14  -0.29%
R/scatterplot.R       +9      +6  +0.79%
R/volcanoplot.R       +7      +6  -0.02%
TOTAL                +97     +76  -0.16%

Results for commit: fe5aec6

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 22, 2024 •
edited
Loading

Unit Tests Summary

  1 files   15 suites   12s ⏱️
 56 tests  43 ✅ 13 💤 0 ❌
538 runs  525 ✅ 13 💤 0 ❌

Results for commit fe5aec6.

♻️ This comment has been updated with latest results.

danielinteractive
danielinteractive reviewed Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BFalquet , looks good, minor thing is that I see some Rplots.pdf files which would be good to remove

@danielinteractive danielinteractive merged commit e12820c into main Mar 25, 2024
24 checks passed
@danielinteractive danielinteractive deleted the 370-again-integration-test-failures@main branch March 25, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielinteractive danielinteractive danielinteractive approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BFalquet @danielinteractive